From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Cooijmans Date: Fri, 24 Feb 2006 23:07:15 +0000 Subject: Re: [KJ] [PATCH] check request_region return value Message-Id: <200602250007.15708.tim@aapopfiets.nl> List-Id: References: <200602242249.22568.tim@aapopfiets.nl> In-Reply-To: <200602242249.22568.tim@aapopfiets.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Friday 24 February 2006 22:58, Jesper Juhl wrote: > On 2/24/06, Tim Cooijmans wrote: > > From: Tim Cooijmans > > > > Check request_region return value in arch/powerpc/platform/chrp/setup.c. > > Passed compilation. > > Looks OK to me, but couldn't this be improved by changing the function > to return an int stating if things are OK or not and then having > caller check the return value and act appropriately? Yes, I thought about that. The reason I didn't do this is that chrp_init2 is assigned to ppc_md.init. ppc_md is a struct machdep_calls, which seems to be an abstraction of machine-dependent stuff. Changing the return type is probably going to break lots of things. Anyway, warning when things fail is better than nothing. Tim _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors