From: Tony Lindgren <tony@atomide.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: OMAP-Linux <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] Make H2 board file compile without irda warning
Date: Fri, 24 Feb 2006 17:10:19 -0800 [thread overview]
Message-ID: <20060225011019.GD5116@atomide.com> (raw)
In-Reply-To: <20060222161650.26516.qmail@web32913.mail.mud.yahoo.com>
* Komal Shah <komal_shah802003@yahoo.com> [060222 09:26]:
> --- Daniel Petrini <d.pensator@gmail.com> wrote:
>
> >
> > Humm, my first idea was exactly like this but I tried to avoid
> > another #ifdef..
> > So what about this new approach, which still avoids #ifdefs although
> > with expense of one flag ?
> >
>
> I am now in confusion :). I like your patch too, but I thought that
> adding #ifdef in board-* files is no harm. So, let's Tony speak :)
Both work, but let's use the smaller codesize one at the expense of
one ifdef :) I'll push Komal's patch today.
Tony
prev parent reply other threads:[~2006-02-25 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 17:54 [PATCH] Make H2 board file compile without irda warning Daniel Petrini
2006-02-21 21:28 ` Komal Shah
2006-02-21 21:54 ` Komal Shah
2006-02-22 13:18 ` Daniel Petrini
2006-02-22 13:40 ` Daniel Petrini
2006-02-22 16:16 ` Komal Shah
2006-02-25 1:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060225011019.GD5116@atomide.com \
--to=tony@atomide.com \
--cc=komal_shah802003@yahoo.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.