From: Al Viro <viro@ftp.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
Ulrich Drepper <drepper@redhat.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] flags parameter for linkat
Date: Sat, 25 Feb 2006 10:13:18 +0000 [thread overview]
Message-ID: <20060225101317.GI27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20060225091606.GA22749@infradead.org>
On Sat, Feb 25, 2006 at 09:16:07AM +0000, Christoph Hellwig wrote:
> Please stop adding these crappy flags argument everywhere, they're also
> creaping like a cancer through the other *at stuff. Just make linkat
> do the righ thing per posix spec for link, and then you can implement
> a posix link based on it in glibc if the user compiles with XOPEN_SOURCE
> or whatever.
It's a bloody bad idea, since XOPEN_SOURCE is nowhere near fine-grained
enough and could be forced by any number of things.
The _real_ issue with flags is the lack of filtering. I.e. we blindly
pass userland argument there, exposing both internal flag values _and_
flags that really shouldn't be exposed that way at all.
prev parent reply other threads:[~2006-02-25 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-23 14:10 [PATCH] flags parameter for linkat Ulrich Drepper
2006-02-23 14:19 ` David Vrabel
2006-02-23 20:26 ` Ralf Baechle
2006-02-25 9:16 ` Christoph Hellwig
2006-02-25 10:13 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060225101317.GI27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=drepper@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.