All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: the war on trailing whitespace
Date: Mon, 27 Feb 2006 15:37:02 -0800	[thread overview]
Message-ID: <20060227153702.375db751.akpm@osdl.org> (raw)
In-Reply-To: <7vhd6kxuea.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
>
> tell the higher echelon folks
>  to do:
> 
>  	$ git repo-config apply.whitespace error
> 
>  in their repositories

That might be reasonable, some might object to tiny amounts of extra work..

In my setup, trailing whitespace purely causes warnings.  But with a
quilt-style thing, it's trivial to unapply the patch, strip it, reapply.

git is different - I'd imagine that if warnings were generated while an
mbox was being applied, it's too much hassle to go and unapply the mbox,
fix the diffs up and then apply the mbox again.

I'd suggest that git have options to a) generate trailing-whitespace
warnings, b) generate trailing-whitespace errors and c) strip trailing
whitespace while applying.   And that the as-shipped default be a).

  parent reply	other threads:[~2006-02-27 23:38 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-26  1:40 the war on trailing whitespace Andrew Morton
2006-02-26  3:38 ` Junio C Hamano
2006-02-26  5:07   ` Andrew Morton
2006-02-26 17:29     ` Linus Torvalds
2006-02-26 18:36       ` Andrew Morton
2006-02-26 20:16         ` Linus Torvalds
2006-02-26 20:26           ` Dave Jones
2006-02-26 20:31             ` Dave Jones
2006-02-27  2:50             ` MIke Galbraith
2006-02-27  9:07               ` Johannes Schindelin
2006-02-27  9:18                 ` Andrew Morton
2006-02-27 23:18                   ` Junio C Hamano
2006-02-27 23:29                     ` Peter Williams
2006-02-28  0:10                       ` Junio C Hamano
2006-02-27 23:37                     ` Andrew Morton [this message]
2006-02-28  9:13                       ` [PATCH] git-apply: war on whitespace -- finishing touches Junio C Hamano
2006-02-28  1:13                     ` [PATCH 1/3] apply: squelch excessive errors and --whitespace=error-all Junio C Hamano
2006-02-28  1:13                     ` [PATCH 2/3] apply --whitespace: configuration option Junio C Hamano
2006-02-28  9:16                       ` Andreas Ericsson
2006-02-28  9:38                         ` Junio C Hamano
2006-02-28  9:46                           ` Andreas Ericsson
2006-02-28  1:13                     ` [PATCH 3/3] git-apply --whitespace=nowarn Junio C Hamano
2006-02-28  3:26                       ` A Large Angry SCM
2006-02-28  5:08                         ` Junio C Hamano
2006-02-27 11:26                 ` the war on trailing whitespace Adrien Beau
2006-02-27 11:41                   ` Andreas Ericsson
2006-02-27 13:31                     ` Uwe Zeisberger
2006-02-27 14:10                       ` Andreas Ericsson
2006-02-27 14:31                         ` Peter Hagervall
2006-02-27 14:40                           ` Johannes Schindelin
2006-02-27 15:22                             ` Randal L. Schwartz
2006-02-27 16:08                         ` Josef Weidendorfer
2006-02-27 16:22                         ` Adrien Beau
2006-02-27 16:37                         ` Uwe Zeisberger
2006-02-27 16:41                           ` Andreas Ericsson
2006-02-27 11:55                   ` Johannes Schindelin
2006-02-27  0:45           ` Junio C Hamano
2006-02-27  2:14             ` [PATCH] apply --whitespace fixes and enhancements Junio C Hamano
2006-02-26 20:29         ` the war on trailing whitespace Junio C Hamano
2006-02-26 19:45       ` Sam Ravnborg
  -- strict thread matches above, loose matches on Subject: below --
2006-02-28  1:07 linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060227153702.375db751.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.