From: Benjamin Marzinski <bmarzins@redhat.com>
To: dm-devel@redhat.com
Subject: dm-multipath [PATCH] "better" return codes.
Date: Mon, 27 Feb 2006 15:11:10 -0600 [thread overview]
Message-ID: <20060227211110.GB7357@ether.msp.redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
I think that these multipathd return codes make more sense (failing if the map
is not a multipath map, and not failing if it has already been added).
-Ben
[-- Attachment #2: returns.patch --]
[-- Type: text/plain, Size: 679 bytes --]
diff -urpN mp-devel-clean/multipathd/main.c mp-devel-patched/multipathd/main.c
--- mp-devel-clean/multipathd/main.c 2006-02-27 15:09:55.000000000 -0600
+++ mp-devel-patched/multipathd/main.c 2006-02-27 15:16:13.000000000 -0600
@@ -569,7 +569,7 @@ ev_add_map (char * devname, struct vecto
if (map_present && dm_type(alias, DEFAULT_TARGET) <= 0) {
condlog(4, "%s: not a multipath map", alias);
FREE(alias);
- return 0;
+ return 1;
}
mpp = find_mp_by_alias(vecs->mpvec, alias);
@@ -709,7 +709,7 @@ ev_add_path (char * devname, struct vect
/*
* allow reconfig of orphaned path here
*/
- if (pp->mpp) return 1;
+ if (pp->mpp) return 0;
}
else {
/*
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2006-02-27 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 21:11 Benjamin Marzinski [this message]
2006-03-02 10:44 ` dm-multipath [PATCH] "better" return codes Christophe Varoqui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060227211110.GB7357@ether.msp.redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.