Re: [KJ] [PATCH] check request_region() return value in arch/ppc and

From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] check request_region() return value in arch/ppc and
Date: Mon, 27 Feb 2006 21:47:03 +0000	[thread overview]
Message-ID: <20060227214703.GA14119@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On 27.02.2006 [22:29:51 +0100], Tim Cooijmans wrote:
> From: Tim Cooijmans <tim@aapopfiets.nl>
> 
> Check request_region() return value and warn on failure.  Note that
> releasing succeeded requests doesn't make much sense, as the calling
> code doesn't know if anything failed.
> 
> The powerpc code has been compile tested.  The ppc code has not been
> tested, but the changes are very similar.

Looks good in general, one small nit.

> Signed-off-by: Tim Cooijmans <tim@aapopfiets.nl>
> ---
> diff -uprN linux-2.6.16-rc5-orig/arch/powerpc/platforms/chrp/setup.c linux-2.6.16-rc5/arch/powerpc/platforms/chrp/setup.c
> --- linux-2.6.16-rc5-orig/arch/powerpc/platforms/chrp/setup.c	2006-02-27 20:36:36.000000000 +0100
> +++ linux-2.6.16-rc5/arch/powerpc/platforms/chrp/setup.c	2006-02-27 21:52:27.000000000 +0100
> @@ -465,18 +465,26 @@ void __init chrp_init_IRQ(void)
>  }
>  
>  void __init
> +chrp_request_region(unsigned long start, unsigned long n, char *desc)
> +{
> +	if (!request_region(start, n, desc)) {
> +		printk(KERN_WARNING "CHRP: unable to allocate %s region.\n", desc);
> +	}

Here and in the other request_region() wrappers, no { } for the one-line
if, please.

Thanks,
Nish

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors