From: Ben Dooks <ben-linux-arm@fluff.org>
To: Koen Martens <linuxarm@metro.cx>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, ben@simtec.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [patch] s3c2412 support
Date: Wed, 1 Mar 2006 09:10:35 +0000 [thread overview]
Message-ID: <20060301091035.GB26072@trinity.fluff.org> (raw)
In-Reply-To: <44045B98.8010405@metro.cx>
On Tue, Feb 28, 2006 at 03:18:00PM +0100, Koen Martens wrote:
> From: Koen Martens <kmartens@sonologic.nl>
>
> Changes are:
> - Added s3c2412-specific files to arch/arm/mach-s3c2410
> - Added s3c2412 detection to arch/arm/mach-s3c2410/cpu.c
> - Added CONFIG_CPU_S3C2412
> - Added s3c2412 specific registers and register addresses to
> various regs-*.h files in include/asm-arm/arch-s3c2410
It would help to split these emails into smaller chunks than all the files
so that comments could be with the chunks that it goes with.
Kconfig.diff - fine, no problems here
Makefile.diff - going to have to remove those #s at somepoint
regs-clock.diff - didn't need to add s3c2412_get_pll, same as s3c2410_get_pll
regs-gpio.diff - group the s3c2412 changes together into larger #ifdefs
regs-irq.diff - looks fine
regs-rtc.diff - two sets of changes here? 2410 and 2412 additions
s3c2412_c.diff - looks fine
s3c2412_h.diff - looks fine
cpu.diff:
the 2412 is an ARM926EJS, so I'd expect the core-ID accessed
via the co-processor registers to be diffeernt, so this could give
the indication of what sort of CPU to try.
this also seems to have the S3C2442 ID patch from the patch-q in it,
please be careful about merging patches like that.
> All changes are preliminary, final documentation is not yet available
> from samsung. We did test on actual hardware, but outside the linux
> kernel (due to limited number of actual chips we have available and
> lack of proper PCB with serial lines exported).
[snip]
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2006-03-01 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 14:18 [patch] s3c2412 support Koen Martens
2006-03-01 9:10 ` Ben Dooks [this message]
2006-03-03 10:34 ` Koen Martens
-- strict thread matches above, loose matches on Subject: below --
2006-02-28 14:16 Koen Martens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301091035.GB26072@trinity.fluff.org \
--to=ben-linux-arm@fluff.org \
--cc=ben@simtec.co.uk \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@metro.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.