Re: o_sync in vfat driver

[Chris Mason <mason@suse.com>]

On Wednesday 01 March 2006 10:00, OGAWA Hirofumi wrote:
> Chris Mason <mason@suse.com> writes:
> > @@ -329,6 +330,11 @@ static int msdos_create(struct inode *di
> >  	d_instantiate(dentry, inode);
> >  out:
> >  	unlock_kernel();
> > +	if (!err && MSDOS_SB(sb)->options.flush) {
> > +		writeback_inode(dir);
> > +		writeback_inode(inode);
> > +		writeback_bdev(sb);
> > +	}
> >  	return err;
> >  }
>
> If buffers is already queued for I/O, and if you don't wait anything,
> the buffers wouldn't be (re-)submited, then those buffers will be
> flushing by normal periodically wb_kupdate() after all.

Just to make sure we're using the same terms, do you mean the pages are marked 
dirty and on the SB's dirty list, or do you mean the page has been through 
writepage and is currently on its way to the disk?

>
> Do you have any plan to address it? Or I'm just missing something?

If you mean the page is just dirty, it will get written by the 
filemap_fdatawrite calls.  If you mean the page is PG_writeback, it is 
already on the way to the disk, so it passes the 'blinking light on the 
memory stick' rule.

-chris