All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Kai Makisara <Kai.Makisara@kolumbus.fi>
Cc: matthew@wil.cx, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI sym53c8xx_2: bigger transfer limits
Date: Wed, 1 Mar 2006 16:29:29 +0100	[thread overview]
Message-ID: <20060301152929.GZ4816@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.63.0602282104040.6272@kai.makisara.local>

On Tue, Feb 28 2006, Kai Makisara wrote:
> This patch enables clustering and sets max_sectors to 0xffff to enable 
> reading and writing of large blocks with tapes (and large transfers with 
> sg). This change is needed after the sg and st drivers started using 
> chained bios through scsi_request_async() in 2.6.16.
> 
> Signed-off-by: Kai Makisara <kai.makisara@kolumbus.fi>
> 
> --- linux-2.6.16-rc5/drivers/scsi/sym53c8xx_2/sym_glue.c	2006-02-04 13:25:48.000000000 +0200
> +++ linux-2.6.16-rc5-k1/drivers/scsi/sym53c8xx_2/sym_glue.c	2006-02-18 09:45:24.000000000 +0200
> @@ -1978,7 +1978,8 @@ static struct scsi_host_template sym2_te
>  	.eh_bus_reset_handler	= sym53c8xx_eh_bus_reset_handler,
>  	.eh_host_reset_handler	= sym53c8xx_eh_host_reset_handler,
>  	.this_id		= 7,
> -	.use_clustering		= DISABLE_CLUSTERING,
> +	.use_clustering		= ENABLE_CLUSTERING,
> +	.max_sectors		= 0xFFFF,

Strictly speaking, the clustering bit is unrelated. I seem to recall
Gerard years ago talking about some sym chips that did not like
clustering, hence it was disabled.

-- 
Jens Axboe


  parent reply	other threads:[~2006-03-01 15:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-28 19:14 [PATCH] SCSI sym53c8xx_2: bigger transfer limits Kai Makisara
2006-02-28 20:41 ` Matthew Wilcox
2006-03-01 15:29 ` Jens Axboe [this message]
2006-03-01 15:39   ` James Bottomley
2006-03-01 15:54     ` Jens Axboe
2006-03-01 16:00     ` Douglas Gilbert
2006-03-01 16:11       ` Jens Axboe
2006-03-01 16:17       ` James Bottomley
2006-03-01 20:34   ` Kai Makisara
2006-03-01 20:43     ` Jens Axboe
2006-03-01 22:24       ` Kai Makisara
2006-03-02  3:57         ` Matthew Wilcox
2006-03-02  7:29         ` Jens Axboe
2006-03-04  8:16           ` Kai Makisara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060301152929.GZ4816@suse.de \
    --to=axboe@suse.de \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.