All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sam Vilain <sam@vilain.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [Fwd: [PATCH 3/5] NFS: Abstract out namespace initialisation [try #2]]
Date: Thu, 2 Mar 2006 08:44:48 +0000	[thread overview]
Message-ID: <20060302084448.GA21902@infradead.org> (raw)
In-Reply-To: <440613FF.4040807@vilain.net>

On Thu, Mar 02, 2006 at 10:37:03AM +1300, Sam Vilain wrote:
> The attached patch abstracts out the namespace initialisation so that 
> temporary namespaces can be set up elsewhere.

Definitily shouldb't be inline.  And until you have a second caller
it's utterly pointless.  So NACK for now.


  reply	other threads:[~2006-03-02  8:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-01 21:37 [Fwd: [PATCH 3/5] NFS: Abstract out namespace initialisation [try #2]] Sam Vilain
2006-03-02  8:44 ` Christoph Hellwig [this message]
2006-03-02 11:35   ` David Howells
2006-03-02 19:52     ` Sam Vilain
2006-03-02 21:12       ` David Howells
2006-03-02 21:53         ` Sam Vilain
2006-03-05  0:34           ` Andrew Morton
2006-03-03 16:52         ` J. Bruce Fields
2006-03-02 20:00 ` Sam Vilain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060302084448.GA21902@infradead.org \
    --to=hch@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.