All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Greg KH <greg@kroah.com>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: what's a platform device?
Date: Thu, 2 Mar 2006 15:39:45 +0000	[thread overview]
Message-ID: <20060302153945.GA28895@flint.arm.linux.org.uk> (raw)
In-Reply-To: <B8F53A5C-A186-478E-A2A9-4797FE56EBE4@kernel.crashing.org>

On Mon, Feb 27, 2006 at 04:25:52PM -0600, Kumar Gala wrote:
> >>>This makes sense, but you seem to be talking about hierarchy more  
> >>>the
> >>>functionality.  I agree in your description of hierarchy.
> >>>
> >>>I was looking at it from a functional point of view, maybe more from
> >>>the device view then from the bus.  I need a struct device type that
> >>>contains resources, a name, an id.  I'll do matching based on name.
> >>> From a functional point of view platform does all this.
> >>>
> >>>Based on your description would you say that a platform_device's
> >>>parent device should always be platform_bus? [I'm getting at the  
> >>>fact
> >>>that we allow pdev->dev.parent to be set by the caller of
> >>>platform_device_add].
> >>>
> >>>Hmm, as I think about this further, I think that its more  
> >>>coincidence
> >>>that the functionality for the "kumar" bus is equivalent to that of
> >>>the "platform" bus.
> >>>
> >>
> >>What about a new bus_type that uses all the sematics of the  
> >>platform_bus.
> >>Doing someting like the following which would allow the caller to  
> >>specify
> >>their own bus_type.
> >>
> >>I'm just trying to avoid duplicating alot of code that already  
> >>exists in
> >>base/platform.c
> >
> >I'm ok with this patch, Russell?
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114072367307531&w=2
> 
> Russell, comments?

No particular opinion on this, other than maybe we want to move the
dev.bus/driver.bus initialisation out of these functions and inline
or something like that - just so there's some distinction between
real platform devices and these other types.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2006-03-02 15:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-22 21:47 what's a platform device? Kumar Gala
2006-02-23  4:39 ` Greg KH
2006-02-23  4:55   ` Kumar Gala
2006-02-23  5:13     ` Greg KH
2006-02-23  7:04       ` Kumar Gala
2006-02-23 19:30         ` Kumar Gala
2006-02-24  1:42           ` Greg KH
2006-02-27 22:25             ` Kumar Gala
2006-03-02 15:39               ` Russell King [this message]
2006-02-23  9:33 ` Russell King
2006-02-23 16:13   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060302153945.GA28895@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=galak@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.