From: Jeff Dike <jdike@addtoit.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add O_NONBLOCK support to FUSE
Date: Thu, 2 Mar 2006 13:04:52 -0500 [thread overview]
Message-ID: <20060302180452.GA9188@ccure.user-mode-linux.org> (raw)
In-Reply-To: <E1FENzJ-0008S7-00@dorka.pomaz.szeredi.hu>
Found the BUG, patch below. Feel free to merge it with the async
patch even though it is signed off on its own.
Jeff
I didn't realize that kobject_put(&fc->kobj) freed fc.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: host-2.6.15-fuse/fs/fuse/dev.c
===================================================================
--- host-2.6.15-fuse.orig/fs/fuse/dev.c 2006-03-01 14:08:40.000000000 -0500
+++ host-2.6.15-fuse/fs/fuse/dev.c 2006-03-01 14:09:04.000000000 -0500
@@ -919,9 +919,9 @@ static int fuse_dev_release(struct inode
}
spin_unlock(&fuse_lock);
if (fc) {
- kobject_put(&fc->kobj);
fasync_helper(-1, file, 0, &fc->fasync);
fc->fasync = NULL;
+ kobject_put(&fc->kobj);
}
return 0;
next prev parent reply other threads:[~2006-03-02 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 2:29 [PATCH] Add O_NONBLOCK support to FUSE Jeff Dike
2006-03-01 9:51 ` Miklos Szeredi
2006-03-02 18:04 ` Jeff Dike [this message]
2006-03-02 19:56 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302180452.GA9188@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.