From: Andrew Morton <akpm@osdl.org>
To: Dave Peterson <dsp@llnl.gov>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
bluesmoke-devel@lists.sourceforge.net
Subject: Re: [PATCH 10/15] EDAC: edac_mc_add_mc() fix [1/2]
Date: Fri, 3 Mar 2006 12:48:02 -0800 [thread overview]
Message-ID: <20060303124802.1c7fb95d.akpm@osdl.org> (raw)
In-Reply-To: <200603031103.08105.dsp@llnl.gov>
Dave Peterson <dsp@llnl.gov> wrote:
>
> On Thursday 02 March 2006 18:31, Andrew Morton wrote:
> > Dave Peterson <dsp@llnl.gov> wrote:
> > > This is part 1 of a 2-part patch set. The code changes are split into
> > > two parts to make the patches more readable.
> >
> > Will the code compile and run with just #1-of-2 applied?
>
> It should compile. Assuming that it does, would it still have been
> preferable to just combine the two into a single patch?
It's better as you had it. First patch moves the functions without
changing them, the second patch changes them. The mantra is "one concept
per patch".
prev parent reply other threads:[~2006-03-03 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 1:48 [PATCH 10/15] EDAC: edac_mc_add_mc() fix [1/2] Dave Peterson
2006-03-03 2:31 ` Andrew Morton
2006-03-03 19:03 ` Dave Peterson
2006-03-03 20:48 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060303124802.1c7fb95d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dsp@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.