From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --temp and --stage=all options to checkout-index.
Date: Fri, 3 Mar 2006 10:13:31 -0500 [thread overview]
Message-ID: <20060303151331.GA16369@spearce.org> (raw)
In-Reply-To: <7vmzg83xro.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> Shawn Pearce <spearce@spearce.org> writes:
>
> > Unfortunately this change lead me down a path which changed the core
> > checkout code also used by apply and read-tree.
>
> ... which makes it much harder to swallow without careful
> inspection X-<.
>
> I think the patch only appears much bigger than it actually is,
> because of reindentation effect coming from "if (to-temp-file)".
> However, I am too tired to carefully examine them tonight, so I
> hope you do not mind my postponing this for now.
Not at all. I read over the diff before sending it and thought it
made the patch look much worse than it really is, simply because
of the reindentation. :-|
Sometimes good 'ole diff ain't that great for conveying a change.
--
Shawn.
next prev parent reply other threads:[~2006-03-03 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-03 1:20 [PATCH] Add --temp and --stage=all options to checkout-index Shawn Pearce
2006-03-03 5:25 ` Junio C Hamano
2006-03-03 15:13 ` Shawn Pearce [this message]
2006-03-05 5:29 ` Junio C Hamano
2006-03-05 8:24 ` Shawn Pearce
2006-03-05 8:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060303151331.GA16369@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.