Re: [PATCH] correct cacheflush loop in zImage

[Olaf Hering <olh@suse.de>]

 On Sat, Mar 04, Olaf Hering wrote:

> 
> Correct the loop for cacheflush. No idea where I copied the code from,
> but the original does not work correct. Maybe the flush is not needed.
> 
> Signed-off-by: Olaf Hering <olh@suse.de>
> 
>  arch/powerpc/boot/crt0.S |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.16-rc5-olh/arch/powerpc/boot/crt0.S
> ===================================================================
> --- linux-2.6.16-rc5-olh.orig/arch/powerpc/boot/crt0.S
> +++ linux-2.6.16-rc5-olh/arch/powerpc/boot/crt0.S
> @@ -45,7 +45,8 @@ _zimage_start:
>  	bdnz	2b
>  
>  	/* Do a cache flush for our text, in case OF didn't */
> -3:	lis	r9,_start@h
> +3:	lis	r9,_start@ha
> +	addi	r9,r9,_start@l
>  	add	r9,r0,r9

I think this part is not required. Segments must be 64k aligned, so the
lower bits will be always zero (modulo the _start offset into .text)