All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: hostmaster@ed-soft.at, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] EFI: Fix gdt load
Date: Sat, 4 Mar 2006 18:45:24 -0800	[thread overview]
Message-ID: <20060304184524.4e9d422f.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0603020755090.28074@montezuma.fsmlabs.com>

Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
>
> On Thu, 2 Mar 2006, Edgar Hucek wrote:
> 
> > This patch makes the kernel bootable again on ia32 EFI systems.
> > 
> > Signed-off-by: Edgar Hucek <hostmaster@ed-soft.at>
> > 
> 
>  	spin_lock(&efi_rt_lock);
>  	local_irq_save(efi_rt_eflags);
> 
> That looks like a race, not to mention that efi_rt_eflags is a global 
> variable. The same strange ordering occurs on unlock, i presume this code 
> 'works' because it's done early during boot?

No, the code's OK.  This is the prologue function.  The epilogue function
does the opposite.   In between, this CPU will dink around with EFI stuff.

And the order is correct too - the lock protects efi_rt_eflags.

  reply	other threads:[~2006-03-05  2:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-02 13:18 [PATCH 1/1] EFI: Fix gdt load Edgar Hucek
2006-03-02 16:12 ` Zwane Mwaikambo
2006-03-05  2:45   ` Andrew Morton [this message]
2006-03-03 10:32 ` Edgar Hucek
2006-03-05  2:43 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060304184524.4e9d422f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hostmaster@ed-soft.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.