All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org
Cc: ben@fluff.org
Subject: [PATCH] define setup_arch() in header file
Date: Sun, 5 Mar 2006 20:44:18 +0000	[thread overview]
Message-ID: <20060305204418.GA7244@home.fluff.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

When running sparse over an ARM build of 2.6.16-rc5, I came
across this error, which is due to setup_arch() being used
be init/main.c, but not being defined in any headers.

This patch adds setup_arch() definition to include/linux/init.h

The warning is:
  arch/arm/kernel/setup.c:730:13: warning: symbol 'setup_arch' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

[-- Attachment #2: setup-define-archcall.patch --]
[-- Type: text/plain, Size: 490 bytes --]

diff -urpN -X ../dontdiff linux-2.6.16-rc5/include/linux/init.h linux-2.6.16-rc5-fixes/include/linux/init.h
--- linux-2.6.16-rc5/include/linux/init.h	2006-02-28 09:05:02.000000000 +0000
+++ linux-2.6.16-rc5-fixes/include/linux/init.h	2006-03-05 20:39:21.000000000 +0000
@@ -69,6 +69,10 @@ extern initcall_t __security_initcall_st
 
 /* Defined in init/main.c */
 extern char saved_command_line[];
+
+/* used by init/main.c */
+extern void setup_arch(char **);
+
 #endif
   
 #ifndef MODULE

             reply	other threads:[~2006-03-05 20:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-05 20:44 Ben Dooks [this message]
2006-03-06  7:03 ` [PATCH] define setup_arch() in header file Andrew Morton
2006-03-09  1:28   ` [2.6 patch] add a proper prototype for setup_arch() Adrian Bunk
2006-03-14  0:45   ` [PATCH] define setup_arch() in header file Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060305204418.GA7244@home.fluff.org \
    --to=ben-linux@fluff.org \
    --cc=ben@fluff.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.