From: Dave Jones <davej@redhat.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, ericvh@gmail.com,
rminnich@lanl.gov
Subject: Re: 9pfs double kfree
Date: Mon, 6 Mar 2006 02:28:23 -0500 [thread overview]
Message-ID: <20060306072823.GF21445@redhat.com> (raw)
In-Reply-To: <20060306072346.GF27946@ftp.linux.org.uk>
On Mon, Mar 06, 2006 at 07:23:46AM +0000, Al Viro wrote:
> On Sun, Mar 05, 2006 at 11:07:11PM -0800, David S. Miller wrote:
> > From: Dave Jones <davej@redhat.com>
> > Date: Mon, 6 Mar 2006 02:04:58 -0500
> >
> > > (I wish we had a kfree variant that NULL'd the target when it was free'd)
> >
> > Excellent idea.
>
> ITYM "poison the pointer variable". Otherwise that sort of crap will go
> unnoticed.
yeah, even better idea. Just like slab debug, but without the overhead
of poisoning the whole object.
I wonder if we could get away with something as simple as..
#define kfree(foo) \
__kfree(foo); \
foo = KFREE_POISON;
?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-03-06 7:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 7:04 9pfs double kfree Dave Jones
2006-03-06 7:07 ` David S. Miller
2006-03-06 7:23 ` Al Viro
2006-03-06 7:28 ` Dave Jones [this message]
2006-03-06 7:56 ` Pekka Enberg
2006-03-06 8:00 ` Dave Jones
2006-03-06 8:16 ` Al Viro
2006-03-06 8:23 ` Pekka Enberg
2006-03-06 8:27 ` Arjan van de Ven
2006-03-06 8:40 ` Kai Makisara
2006-03-06 9:34 ` Al Viro
2006-03-06 22:07 ` Pavel Machek
2006-03-09 14:48 ` Luke-Jr
2006-03-06 7:26 ` Balbir Singh
2006-03-06 7:31 ` Dave Jones
2006-03-06 7:39 ` Balbir Singh
2006-03-07 0:37 ` Andrew Morton
2006-03-07 1:04 ` Eric Van Hensbergen
2006-03-07 2:20 ` Latchesar Ionkov
2006-03-07 1:49 ` Latchesar Ionkov
2006-03-07 12:43 ` [PATCH] v9fs: fix for access to unitialized variables or freed memory Latchesar Ionkov
2006-03-07 23:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060306072823.GF21445@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rminnich@lanl.gov \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.