From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: Libvolume incorrectly detects FAT32
Date: Mon, 06 Mar 2006 22:37:20 +0000 [thread overview]
Message-ID: <20060306223720.GC32389@vrfy.org> (raw)
In-Reply-To: <20060306215704.35f12840@silver>
On Mon, Mar 06, 2006 at 10:59:31PM +0100, Michael Buesch wrote:
> On Monday 06 March 2006 21:57, iSteve wrote:
> > Hello,
> > I'm having one silly partition, which has remnants of previous FAT32 filesystem
> > on it, a LILO bootloader on it and ext2 filesystem spaning all over the
> > partition.
> >
> > The first 512B look exactly like a valid FAT partition header would, except the
> > magic is "LILO".
> >
> > I've looked at the sources for FAT detection, and I noted that when a FAT-like
> > filesystem misses magic, it's still considered valid, since as comment says,
> > some old floppies may lack it. I consider this point valid, however, this
> > causes my partition to be detected, incorrectly, as FAT32.
> >
> > My proposed solution is to compare magic if FAT32 is assumed, and if magic will
> > not match for FAT32, consider it a failure; floppies that old that they lack
> > any magic will most likely not be formatted in FAT32.
> >
> > Trivial patch is attached, comments/complaints?:)
>
> Yes, I fear users of stupid digicams may get hit by this.
> The Formating option on cheap digicams may sometimes be buggy implemented.
> I think you should instead do a
> dd if=/dev/zero of=/dev/partition bsQ2 count=1
> and reformat your partition.
Yes, just use a sane formatting program like everything which is
libparted based. The usual Linux commandline formatters are horribly
broken and I gave up to talk to the ignorant maintainers. Just zero-out
the device at the beginning _and_ the end of the device if you reformat it
with a new filesystem type. Or use a libparted or similar based program.
Thanks,
Kay
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2006-03-06 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 20:57 Libvolume incorrectly detects FAT32 iSteve
2006-03-06 21:59 ` Michael Buesch
2006-03-06 22:37 ` Kay Sievers [this message]
2006-03-07 17:01 ` iSteve
2006-03-07 17:15 ` Kay Sievers
2006-03-07 17:32 ` iSteve
2006-03-07 21:47 ` Michael Buesch
2006-03-08 5:57 ` iSteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060306223720.GC32389@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.