All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, neilb@cse.unsw.edu.au
Subject: Re: [Patch] Wrong error handling in nfs4acl
Date: Tue, 7 Mar 2006 17:58:09 -0500	[thread overview]
Message-ID: <20060307225809.GC14147@fieldses.org> (raw)
In-Reply-To: <1141761420.7561.7.camel@alice>

On Tue, Mar 07, 2006 at 08:57:00PM +0100, Eric Sesterhenn wrote:
> hi,
> 
> this fixes coverity id #3. Coverity detected dead code,
> since the == -1 comparison only returns 0 or 1 to error.
> Therefore the if ( error < 0 ) statement was always false.
> Seems that this was an if( error = nfs4... ) statement some time
> ago, which got broken during cleanup.
> Just compile tested.
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

Thanks!  Applied to my tree.--b.

  reply	other threads:[~2006-03-07 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-07 19:57 [Patch] Wrong error handling in nfs4acl Eric Sesterhenn
2006-03-07 22:58 ` J. Bruce Fields [this message]
2006-03-07 23:06 ` Neil Brown
2006-03-07 23:15   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060307225809.GC14147@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    --cc=snakebyte@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.