From: "David S. Miller" <davem@davemloft.net>
To: rdunlap@xenotime.net
Cc: netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexandra.Kossovsky@oktetlabs.ru, ak@suse.de, akpm@osdl.org,
torvalds@osdl.org
Subject: Re: [PATCH] compat. ifconf: fix limits
Date: Wed, 08 Mar 2006 16:46:27 -0800 (PST) [thread overview]
Message-ID: <20060308.164627.81771250.davem@davemloft.net> (raw)
In-Reply-To: <20060308091608.c56360dd.rdunlap@xenotime.net>
From: "Randy.Dunlap" <rdunlap@xenotime.net>
Date: Wed, 8 Mar 2006 09:16:08 -0800
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> A recent change to compat. dev_ifconf() in fs/compat_ioctl.c
> causes ifconf data to be truncated 1 entry too early when copying it
> to userspace. The correct amount of data (length) is returned,
> but the final entry is empty (zero, not filled in).
> The for-loop 'i' check should use <= to allow the final struct
> ifreq32 to be copied. I also used the ifconf-corruption program
> in kernel bugzilla #4746 to make sure that this change does not
> re-introduce the corruption.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Good catch, applied. Thanks Randy.
Is this one relevant for -stable?
next prev parent reply other threads:[~2006-03-09 0:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 17:16 [PATCH] compat. ifconf: fix limits Randy.Dunlap
2006-03-09 0:46 ` David S. Miller [this message]
2006-03-09 1:41 ` Randy.Dunlap
2006-03-09 1:41 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060308.164627.81771250.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Alexandra.Kossovsky@oktetlabs.ru \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.