All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Anderson <andmike@us.ibm.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH] aic94xx nexus loss time value
Date: Tue, 7 Mar 2006 16:57:05 -0800	[thread overview]
Message-ID: <20060308005705.GA1516@us.ibm.com> (raw)

The nexus loss time value should not be used for an upper level timeout
value. The nexus loss time is for connection request retries. The usage of
the nexus loss time value + HZ (3 seconds) for sdev->timeout leads to
timeouts under load (Bug 6046).

Signed-off-by: Mike Anderson <andmike@us.ibm.com>

 drivers/scsi/sas/sas_scsi_host.c |    4 ----
 1 files changed, 4 deletions(-)

Index: aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_scsi_host.c
===================================================================
--- aic94xx-sas-2.6-patched.orig/drivers/scsi/sas/sas_scsi_host.c	2006-03-06 10:42:59.000000000 -0800
+++ aic94xx-sas-2.6-patched/drivers/scsi/sas/sas_scsi_host.c	2006-03-07 15:42:07.000000000 -0800
@@ -585,10 +585,6 @@ int sas_slave_configure(struct scsi_devi
 		scsi_deactivate_tcq(scsi_dev, 1);
 	}
 
-	if (rdev->I_T_nexus_loss_timeout > 0)
-		scsi_dev->timeout = HZ +
-			msecs_to_jiffies(rdev->I_T_nexus_loss_timeout);
-
 	return 0;
 }
 

                 reply	other threads:[~2006-03-08  0:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060308005705.GA1516@us.ibm.com \
    --to=andmike@us.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.