From: Matthew Wilcox <matthew@wil.cx>
To: akpm@osdl.org
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org, bunk@stusta.de
Subject: Re: [patch 02/28] drivers/scsi/aic7xxx/: possible cleanups
Date: Wed, 8 Mar 2006 05:22:18 -0700 [thread overview]
Message-ID: <20060308122218.GH7301@parisc-linux.org> (raw)
In-Reply-To: <200603080816.k288G72x002153@shell0.pdx.osdl.net>
On Wed, Mar 08, 2006 at 12:14:18AM -0800, akpm@osdl.org wrote:
> From: Adrian Bunk <bunk@stusta.de>
>
> - make needlessly global code static
>
> - #if 0 the following unused global functions:
> - aic79xx_core.c: ahd_print_scb
> - aic79xx_core.c: ahd_suspend
> - aic79xx_core.c: ahd_resume
> - aic79xx_core.c: ahd_dump_scbs
> - aic79xx_osm.c: ahd_softc_comp
>
>
> @@ -155,7 +155,7 @@ typedef enum {
> AHDMSG_1B,
> AHDMSG_2B,
> AHDMSG_EXT
> -} ahd_msgtype;
> + } ahd_msgtype;
> static int ahd_sent_msg(struct ahd_softc *ahd, ahd_msgtype type,
> u_int msgval, int full);
> static int ahd_parse_msg(struct ahd_softc *ahd,
- Introduces some wrong whitespace changes
> @@ -238,10 +238,33 @@ static int ahd_handle_target_cmd(struct
> struct target_cmd *cmd);
> #endif
>
> +static int ahd_abort_scbs(struct ahd_softc *ahd, int target,
> + char channel, int lun, u_int tag,
> + role_t role, uint32_t status);
- prototypes some functions, while ...
> @@ -295,11 +318,44 @@ ahd_set_active_fifo(struct ahd_softc *ah
> }
> }
>
> +static __inline void
> +ahd_unbusy_tcl(struct ahd_softc *ahd, u_int tcl)
> +{
> + ahd_busy_tcl(ahd, tcl, SCB_LIST_NULL);
> +}
> +
> +/*
> + * Determine whether the sequencer reported a residual
> + * for this SCB/transaction.
> + */
> +static __inline void
> +ahd_update_residual(struct ahd_softc *ahd, struct scb *scb)
> +{
> + uint32_t sgptr;
> +
> + sgptr = ahd_le32toh(scb->hscb->sgptr);
> + if ((sgptr & SG_STATUS_VALID) != 0)
> + ahd_calc_residual(ahd, scb);
> +}
> +
> +static __inline void
> +ahd_complete_scb(struct ahd_softc *ahd, struct scb *scb)
> +{
> + uint32_t sgptr;
> +
> + sgptr = ahd_le32toh(scb->hscb->sgptr);
> + if ((sgptr & SG_STATUS_VALID) != 0)
> + ahd_handle_scb_status(ahd, scb);
> + else
> + ahd_done(ahd, scb);
> +}
> +
> +
- ... moving others around. Consistency?
next prev parent reply other threads:[~2006-03-08 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 8:14 [patch 02/28] drivers/scsi/aic7xxx/: possible cleanups akpm
2006-03-08 12:22 ` Matthew Wilcox [this message]
2006-03-08 13:31 ` [2.6 patch] " Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060308122218.GH7301@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.