From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'David Gibson'" <david@gibson.dropbear.id.au>
Cc: "'Zhang, Yanmin'" <yanmin_zhang@linux.intel.com>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ftruncate on huge page couldn't extend hugetlb file
Date: Wed, 8 Mar 2006 16:12:13 -0800 [thread overview]
Message-ID: <200603090012.k290CDg13307@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060308235805.GC17590@localhost.localdomain>
David Gibson wrote on Wednesday, March 08, 2006 3:58 PM
> > Hmm?? I don't think you need to extend the reservation when extending
> > hugetlb file via ftruncate. You don't have any vma that pass beyond
> > current size. So making a reservation is a wrong thing to do here.
>
> Fwiw, I think truncate *should* extend the reservation. We have a
> separate thread arguing about whether we should be reserving by inode
> length, as I've implemented, or by which ranges are actually mapped
> (as apw's old path implemented). As long as it *is* by inode length -
> so it's conceptually all about the logical file in hugetlbfs, not
> about any of its mappings - I think it makes sense for an extending
> truncate() to extend the reservation. It's not reserving them for any
> particular mapping, it's reserving them for page cache pages.
But you already make reservation at mmap time. If you reserve it again
when extending the file, won't you double count?
- Ken
next prev parent reply other threads:[~2006-03-09 0:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-06 6:21 [PATCH] hugetlb_no_page might break hugetlb quota Zhang, Yanmin
2006-03-06 8:15 ` Chen, Kenneth W
2006-03-06 9:06 ` Zhang, Yanmin
2006-03-08 3:14 ` Zhang, Yanmin
2006-03-08 3:24 ` [PATCH] ftruncate on huge page couldn't extend hugetlb file Zhang, Yanmin
[not found] ` <20060307222148.76e5dc45.akpm@osdl.org>
2006-03-08 6:54 ` Zhang, Yanmin
2006-03-08 18:28 ` Chen, Kenneth W
2006-03-08 23:58 ` David Gibson
2006-03-09 0:12 ` Chen, Kenneth W [this message]
2006-03-09 0:22 ` 'David Gibson'
2006-03-09 0:33 ` Chen, Kenneth W
2006-03-09 1:03 ` 'David Gibson'
-- strict thread matches above, loose matches on Subject: below --
2006-03-08 19:03 Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603090012.k290CDg13307@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.