From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
tony.luck@intel.com, jschopp@austin.ibm.com, haveblue@us.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)
Date: Thu, 09 Mar 2006 04:56:04 +0000 [thread overview]
Message-ID: <200603090556.06226.ak@suse.de> (raw)
In-Reply-To: <20060309040055.21f3ec2d.akpm@osdl.org>
On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > + /* we can use kmalloc() in run time */
> > + do {
> > + table_size = zone->wait_table_size
> > + * sizeof(wait_queue_head_t);
> > + zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
>
> Again, GFP_KERNEL would be better is possible.
>
> Won't this place the node's wait_table into a different node's memory?
Yes, kmalloc_node would be better.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
tony.luck@intel.com, jschopp@austin.ibm.com, haveblue@us.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)
Date: Thu, 9 Mar 2006 05:56:04 +0100 [thread overview]
Message-ID: <200603090556.06226.ak@suse.de> (raw)
In-Reply-To: <20060309040055.21f3ec2d.akpm@osdl.org>
On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > + /* we can use kmalloc() in run time */
> > + do {
> > + table_size = zone->wait_table_size
> > + * sizeof(wait_queue_head_t);
> > + zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
>
> Again, GFP_KERNEL would be better is possible.
>
> Won't this place the node's wait_table into a different node's memory?
Yes, kmalloc_node would be better.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
tony.luck@intel.com, jschopp@austin.ibm.com, haveblue@us.ibm.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)
Date: Thu, 9 Mar 2006 05:56:04 +0100 [thread overview]
Message-ID: <200603090556.06226.ak@suse.de> (raw)
In-Reply-To: <20060309040055.21f3ec2d.akpm@osdl.org>
On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> >
> > + /* we can use kmalloc() in run time */
> > + do {
> > + table_size = zone->wait_table_size
> > + * sizeof(wait_queue_head_t);
> > + zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
>
> Again, GFP_KERNEL would be better is possible.
>
> Won't this place the node's wait_table into a different node's memory?
Yes, kmalloc_node would be better.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-09 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 13:42 [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table) Yasunori Goto
2006-03-08 13:42 ` Yasunori Goto
2006-03-08 13:42 ` Yasunori Goto
2006-03-09 12:00 ` [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3 Andrew Morton
2006-03-09 12:00 ` [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table) Andrew Morton
2006-03-09 12:00 ` Andrew Morton
2006-03-09 4:56 ` Andi Kleen [this message]
2006-03-09 4:56 ` Andi Kleen
2006-03-09 4:56 ` Andi Kleen
2006-03-10 7:20 ` Yasunori Goto
2006-03-10 7:20 ` Yasunori Goto
2006-03-10 7:20 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603090556.06226.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.