From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Dickson Subject: Re: [PATCH 001 of 14] knfsd: Change the store of auth_domains to not be a 'cache'. Date: Thu, 9 Mar 2006 09:26:37 -0700 Message-ID: <20060309092637.4d008f97.dickson@permanentmail.com> References: <20060309174755.24381.patches@notabene> <1060309065127.24521@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: akpm@osdl.org, nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 4.30) id 1FHNyb-0007MZ-AS for nfs@lists.sourceforge.net; Thu, 09 Mar 2006 08:26:57 -0800 Received: from rune.pobox.com ([208.210.124.79]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1FHNyZ-0004HX-2P for nfs@lists.sourceforge.net; Thu, 09 Mar 2006 08:26:57 -0800 To: NeilBrown In-Reply-To: <1060309065127.24521@suse.de> Sender: nfs-admin@lists.sourceforge.net Errors-To: nfs-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Post: List-Help: List-Subscribe: , List-Archive: On Thu, 9 Mar 2006 17:51:27 +1100, NeilBrown wrote: > struct auth_domain *unix_domain_find(char *name) > { > - [code deletions removed] > + struct auth_domain *rv; > + struct unix_domain *new = NULL; > > - [code deletions removed] > + rv = auth_domain_lookup(name, NULL); > + while(1) { > + if (rv != &new->h) { > + if (new) auth_domain_put(&new->h); > + return rv; > + } > + new = kmalloc(sizeof(*new), GFP_KERNEL); > + if (new == NULL) > + return NULL; My C skills are a bit rusty, but is seems the value of new is offsetted while still NULL. I could not find any further updates in the patch series. -Paul ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932513AbWCIQ0r (ORCPT ); Thu, 9 Mar 2006 11:26:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932444AbWCIQ0r (ORCPT ); Thu, 9 Mar 2006 11:26:47 -0500 Received: from rune.pobox.com ([208.210.124.79]:22436 "EHLO rune.pobox.com") by vger.kernel.org with ESMTP id S932648AbWCIQ0q (ORCPT ); Thu, 9 Mar 2006 11:26:46 -0500 Date: Thu, 9 Mar 2006 09:26:37 -0700 From: Paul Dickson To: NeilBrown Cc: akpm@osdl.org, nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 001 of 14] knfsd: Change the store of auth_domains to not be a 'cache'. Message-Id: <20060309092637.4d008f97.dickson@permanentmail.com> In-Reply-To: <1060309065127.24521@suse.de> References: <20060309174755.24381.patches@notabene> <1060309065127.24521@suse.de> X-Mailer: Sylpheed version 2.2.0beta7 (GTK+ 2.8.13; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Mar 2006 17:51:27 +1100, NeilBrown wrote: > struct auth_domain *unix_domain_find(char *name) > { > - [code deletions removed] > + struct auth_domain *rv; > + struct unix_domain *new = NULL; > > - [code deletions removed] > + rv = auth_domain_lookup(name, NULL); > + while(1) { > + if (rv != &new->h) { > + if (new) auth_domain_put(&new->h); > + return rv; > + } > + new = kmalloc(sizeof(*new), GFP_KERNEL); > + if (new == NULL) > + return NULL; My C skills are a bit rusty, but is seems the value of new is offsetted while still NULL. I could not find any further updates in the patch series. -Paul