From: Pavel Machek <pavel@suse.cz>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Chris Mason <mason@suse.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org, mmlnx@us.ibm.com
Subject: Re: [PATCH] fix kexec asm
Date: Thu, 9 Mar 2006 10:35:51 +0100 [thread overview]
Message-ID: <20060309093551.GA2830@elf.ucw.cz> (raw)
In-Reply-To: <m1zmk1y3j1.fsf@ebiederm.dsl.xmission.com>
On Út 07-03-06 21:16:34, Eric W. Biederman wrote:
> Chris Mason <mason@suse.com> writes:
>
> > From: Michael Matz <matz@suse.de>
> >
> > While testing kexec and kdump we hit problems where the new kernel would
> > freeze or instantly reboot. The easiest way to trigger it was to kexec a
> > kernel compiled for CONFIG_M586 on an athlon cpu. Compiling
> > for CONFIG_MK7 instead would work fine.
> >
> > The patch below fixes a few problems with the kexec inline asm.
>
> Thanks. Specifying the stomp of %eax in load_segments is definitely
> good. The memory stomp looks excessive and if this was a fast path
> I would worry about it. As it is better safe than sorry.
Why excessive? It reloads %ss, AFAICS; at that point, all the stack
potentially changes from gcc's POV.
Pavel
--
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
prev parent reply other threads:[~2006-03-09 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-08 2:35 [PATCH] fix kexec asm Chris Mason
2006-03-08 4:16 ` Eric W. Biederman
2006-03-09 9:35 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060309093551.GA2830@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=mmlnx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.