Re: ACL on NFS, how make it work?

[Andreas Gruenbacher <agruen@suse.de>]

Hello,

the patch looks good.

On Thursday 09 March 2006 02:49, J. Bruce Fields wrote:
> nfsd4: fix acl xattr length return
Actually all versions, not only v4.
>
> We should be using the length from the second vfs_getxattr, in case it
> changed.  (Note: there's still a small race here; we could end up returning
> -ENOMEM if the length increased between the first and second call.  Oh
> well; I'm not sure it's worth spending a lot of effort to fix that.)
>
> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
> ---
>
>  fs/nfsd/vfs.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 5320e5a..ac3a8e4 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -371,7 +371,6 @@ out_nfserr:
>  static ssize_t nfsd_getxattr(struct dentry *dentry, char *key, void **buf)
>  {
>  	ssize_t buflen;
> -	int error;
>
>  	buflen = vfs_getxattr(dentry, key, NULL, 0);
>  	if (buflen <= 0)
> @@ -381,10 +380,7 @@ static ssize_t nfsd_getxattr(struct dent
>  	if (!*buf)
>  		return -ENOMEM;
>
> -	error = vfs_getxattr(dentry, key, *buf, buflen);
> -	if (error < 0)
> -		return error;
> -	return buflen;
> +	return vfs_getxattr(dentry, key, *buf, buflen);
>  }
>  #endif

Thanks,
Andreas

-- 
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX Products GmbH / Novell Inc.


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs