From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Minor mips-related patchlet
Date: Sat, 11 Mar 2006 15:01:05 +0000 [thread overview]
Message-ID: <200603111501.06862.paul@codesourcery.com> (raw)
In-Reply-To: <20060215124530.GC29709@networkno.de>
> Index: target-mips/op_mem.c
>...
> +extern void dump_sc (void);
Having function prototypes in .c files is wrong. I added it to exec.h instead.
> +void glue(op_store_T2_gpr_gpr, REG) (void)
> +{
> + env->gpr[REG] = T2;
> + RETURN();
> +}
I don't think there's any point adding this unless it's actually used. The ARM
target doesn't have this op either.
Paul
next prev parent reply other threads:[~2006-03-11 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 12:45 [Qemu-devel] [PATCH] Minor mips-related patchlet Thiemo Seufer
2006-03-11 15:01 ` Paul Brook [this message]
2006-03-13 14:41 ` Thiemo Seufer
2006-03-13 14:48 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603111501.06862.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.