All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Aristeu Sergio Rozanski Filho <aris@mandriva.com>
Cc: fbl@conectiva.com.br, "Björn Östby" <Bjorn.Ostby@combitech.se>,
	linuxppc-embedded@ozlabs.org
Subject: Re: SCCx UART status on 8xx
Date: Sat, 11 Mar 2006 16:17:02 -0600	[thread overview]
Message-ID: <20060311221702.GA26734@dmt.cnet> (raw)
In-Reply-To: <20060220141830.GA7228@oops.ghostprotocols.net>


Aris, 

Can you please prepare a detailed description of what the 
patch is doing and why?

Thanks

On Mon, Feb 20, 2006 at 11:18:35AM -0300, Aristeu Sergio Rozanski Filho wrote:
> Index: stable/drivers/serial/cpm_uart/cpm_uart_cpm1.c
> ===================================================================
> --- stable.orig/drivers/serial/cpm_uart/cpm_uart_cpm1.c	2006-02-17 17:11:37.000000000 -0200
> +++ stable/drivers/serial/cpm_uart/cpm_uart_cpm1.c	2006-02-17 17:15:57.000000000 -0200
> @@ -139,24 +139,31 @@
>  void scc1_lineif(struct uart_cpm_port *pinfo)
>  {
>  	/* XXX SCC1: insert port configuration here */
> +	cpmp->cp_sicr &= 0xFFFFFFC0;
>  	pinfo->brg = 1;
>  }
>  
>  void scc2_lineif(struct uart_cpm_port *pinfo)
>  {
>  	/* XXX SCC2: insert port configuration here */
> +	cpmp->cp_sicr &= 0xFFFFC0FF;
> +	cpmp->cp_sicr |= 0x00000900;
>  	pinfo->brg = 2;
>  }
>  
>  void scc3_lineif(struct uart_cpm_port *pinfo)
>  {
>  	/* XXX SCC3: insert port configuration here */
> +	cpmp->cp_sicr &= 0xFFC0FFFF;
> +	cpmp->cp_sicr |= 0x00140000;
>  	pinfo->brg = 3;
>  }
>  
>  void scc4_lineif(struct uart_cpm_port *pinfo)
>  {
>  	/* XXX SCC4: insert port configuration here */
> +	cpmp->cp_sicr &= 0xC0FFFFFF;
> +	cpmp->cp_sicr |= 0x1BFFFFFF;
>  	pinfo->brg = 4;
>  }
>  

> Index: stable/drivers/serial/cpm_uart/cpm_uart_core.c
> ===================================================================
> --- stable.orig/drivers/serial/cpm_uart/cpm_uart_core.c	2005-12-07 15:30:42.000000000 -0200
> +++ stable/drivers/serial/cpm_uart/cpm_uart_core.c	2005-12-08 12:39:11.000000000 -0200
> @@ -467,6 +467,7 @@
>  	/* free interrupt handler */
>  	free_irq(port->irq, port);
>  
> +#if 0
>  	/* If the port is not the console, disable Rx and Tx. */
>  	if (!(pinfo->flags & FLAG_CONSOLE)) {
>  		/* Wait for all the BDs marked sent */
> @@ -492,6 +493,7 @@
>  		/* Shut them really down */
>  		cpm_line_cr_cmd(line, CPM_CR_STOP_TX);
>  	}
> +#endif 
>  }
>  
>  static void cpm_uart_set_termios(struct uart_port *port,
> @@ -896,7 +898,7 @@
>  		pinfo->sccp->scc_gsmrl &= ~(SCC_GSMRL_ENR | SCC_GSMRL_ENT);
>  	}
>  
> -	ret = cpm_uart_allocbuf(pinfo, 0);
> +	ret = cpm_uart_allocbuf(pinfo, 1);
>  
>  	if (ret)
>  		return ret;
> @@ -912,10 +914,12 @@
>  
>  static void cpm_uart_release_port(struct uart_port *port)
>  {
> +#if 0
>  	struct uart_cpm_port *pinfo = (struct uart_cpm_port *)port;
>  
>  	if (!(pinfo->flags & FLAG_CONSOLE))
>  		cpm_uart_freebuf(pinfo);
> +#endif
>  }
>  
>  /*

  reply	other threads:[~2006-03-11 19:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 13:37 SCCx UART status on 8xx Björn Östby
2006-02-20 14:18 ` Aristeu Sergio Rozanski Filho
2006-03-11 22:17   ` Marcelo Tosatti [this message]
2006-02-20 20:15 ` Wolfgang Denk
2006-02-20 20:43   ` Dan Malek
  -- strict thread matches above, loose matches on Subject: below --
2006-02-21 11:01 Björn Östby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060311221702.GA26734@dmt.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=Bjorn.Ostby@combitech.se \
    --cc=aris@mandriva.com \
    --cc=fbl@conectiva.com.br \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.