From: Andrew Morton <akpm@osdl.org>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: christopher.leech@intel.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine
Date: Sun, 12 Mar 2006 03:04:35 -0800 [thread overview]
Message-ID: <20060312030435.6a5ff2c2.akpm@osdl.org> (raw)
In-Reply-To: <20060312104728.GA25301@2ka.mipt.ru>
Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
>
> On Fri, Mar 10, 2006 at 06:29:46PM -0800, Leech, Christopher (christopher.leech@intel.com) wrote:
> > From: Chris Leech [mailto:christopher.leech@intel.com]
> > Sent: Friday, March 10, 2006 6:29 PM
> > To:
> > Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine
> >
> >
> > Adds a new ioatdma driver
>
> enumerate_dma_channels() is still broken, if it can not fail add NOFAIL
> gfp flag.
The __GFP_NOFAIL flag is there to mark lame-and-buggy-code which doesn't
know how to handle ENOMEM. I went through the kernel, found all the
retry-until-it-works loops and consolidated their behaviour in the page
allocator instead.
Really we should fix them all up. Adding new users of __GFP_NOFAIL
would not be good.
prev parent reply other threads:[~2006-03-12 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-11 2:29 [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine Leech, Christopher
2006-03-12 10:47 ` Evgeniy Polyakov
2006-03-12 11:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060312030435.6a5ff2c2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=christopher.leech@intel.com \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.