From: Wang Jian <lark@linux.net.cn>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver
Date: Mon, 13 Mar 2006 01:04:35 +0800 [thread overview]
Message-ID: <20060313005521.8B6C.LARK@linux.net.cn> (raw)
In-Reply-To: <20060312004036.2C6F0353A05@atlas.denx.de>
Hi Wolfgang Denk,
This commit breaks compile of boards without <asm/arch/platform.h>.
Example:
$ make Sandpoint8240_config; make
Relevant files
$ grep -R asm/arch/platform.h *
board/cm41xx/cm41xx.c:#include <asm/arch/platform.h>
board/cm4008/cm4008.c:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/interrupts.c:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/lowlevel_init.S:#include <asm/arch/platform.h>
cpu/arm920t/ks8695/serial.c:#include <asm/arch/platform.h>
drivers/ks8695eth.c:#include <asm/arch/platform.h>
grep: include/asm/arch: No such file or directory
grep: include/asm-ppc/arch: No such file or directory
$ find . -name platform.h
./include/asm-microblaze/platform.h
./include/asm-arm/arch-ks8695/platform.h
On Sun, 12 Mar 2006 01:40:36 +0100, Wolfgang Denk <wd@denx.de> wrote:
> In message <42A06968.3050706@moreton.com.au> you wrote:
> >
> > Move the c-preprocessor conditional check for compiling the ks8695eth
> > driver code to after including the headers. Otherwise it can never
> > be compiled in.
>
> Applied. But please provide a proper CHANGELOG entry next time!
>
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering: Embedded and Realtime Systems, Embedded Linux
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> In an infinite universe all things are possible, including the possi-
> bility that the universe does not exist.
> - Terry Pratchett, _The Dark Side of the Sun_
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid\x110944&bid$1720&dat\x121642
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
--
lark
next prev parent reply other threads:[~2006-03-12 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 14:30 [U-Boot-Users] [PATCH] fix conditional for including ks8695eth driver Greg Ungerer
2006-03-12 0:40 ` Wolfgang Denk
2006-03-12 17:04 ` Wang Jian [this message]
2006-03-12 21:15 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313005521.8B6C.LARK@linux.net.cn \
--to=lark@linux.net.cn \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.