From: Shawn Pearce <spearce@spearce.org>
To: "Randal L. Schwartz" <merlyn@stonehenge.com>
Cc: git@vger.kernel.org
Subject: Re: [BUG] imap-send.c fails to build on OSX
Date: Mon, 13 Mar 2006 00:03:38 -0500 [thread overview]
Message-ID: <20060313050338.GA18154@spearce.org> (raw)
In-Reply-To: <86zmjvhsru.fsf@blue.stonehenge.com>
"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:
> >>>>> "Shawn" == Shawn Pearce <spearce@spearce.org> writes:
>
> Shawn> Workarounds for compiling on MacOS X.
> Shawn> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
>
> Shawn> This should fix the build issues on Mac OS X. Not tested on other
> Shawn> (possibly) more important platforms, like Linux. :-)
>
> My C is a bit rusty, but wouldn't that provide a definition for vasprintf when
> the libc is *also* providing a definition? Might that not also break other
> apps that want to link with this?
>
> Maybe the right solution is to rename this local implementation so that it
> can't conflict, like "git_vasprintf", or to include it only when the libc
> doesn't provide it.
Your right. But I figured it wasn't a big deal since this is just
an application and not library code. Nobody should be linking
against it.
Perhaps the better solution is to rename the provided implementation
to git_; maybe even better to move it off to the compat library
area where other should-have-been-provided-by-the-OS definitions are.
--
Shawn.
prev parent reply other threads:[~2006-03-13 5:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 14:44 [BUG] imap-send.c fails to build on OSX Randal L. Schwartz
2006-03-12 19:08 ` Randal L. Schwartz
2006-03-13 4:25 ` Shawn Pearce
2006-03-13 4:29 ` Randal L. Schwartz
2006-03-13 5:03 ` Shawn Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313050338.GA18154@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.