From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FIoEC-0000vd-Sz
	for qemu-devel@nongnu.org; Mon, 13 Mar 2006 09:40:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FIoEB-0000ux-Bm
	for qemu-devel@nongnu.org; Mon, 13 Mar 2006 09:40:56 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FIoEB-0000up-8K
	for qemu-devel@nongnu.org; Mon, 13 Mar 2006 09:40:55 -0500
Received: from [193.7.176.20] (helo=bender.bawue.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1FIoIA-0007Fi-Fc
	for qemu-devel@nongnu.org; Mon, 13 Mar 2006 09:45:02 -0500
Date: Mon, 13 Mar 2006 14:41:15 +0000
Subject: Re: [Qemu-devel] [PATCH] Minor mips-related patchlet
Message-ID: <20060313144115.GA10773@networkno.de>
References: <20060215124530.GC29709@networkno.de>
	<200603111501.06862.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200603111501.06862.paul@codesourcery.com>
From: Thiemo Seufer <ths@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Sat, Mar 11, 2006 at 03:01:05PM +0000, Paul Brook wrote:
> > Index: target-mips/op_mem.c
> >...
> > +extern void dump_sc (void);
> 
> Having function prototypes in .c files is wrong. I added it to exec.h instead.
> 
> > +void glue(op_store_T2_gpr_gpr, REG) (void)
> > +{
> > +    env->gpr[REG] = T2;
> > +    RETURN();
> > +}
> 
> I don't think there's any point adding this unless it's actually used. The ARM 
> target doesn't have this op either.

Should it then be removed for other targets where it presumably isn't
used as well?


Thiemo