From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: Re: [PATCH] xm: cleanup sched-sedf and tests Date: Mon, 13 Mar 2006 10:03:23 -0600 Message-ID: <20060313160323.GH14363@us.ibm.com> References: <20060307234243.GH15536@us.ibm.com> <20060310003937.GE16724@leeni.uk.xensource.com> <20060310200640.GD14363@us.ibm.com> <20060311145103.GC13877@leeni.uk.xensource.com> <20060313153648.GG14363@us.ibm.com> <20060313155346.GI2928@leeni.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20060313155346.GI2928@leeni.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ewan Mellor Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org * Ewan Mellor [2006-03-13 09:54]: > On Mon, Mar 13, 2006 at 09:36:48AM -0600, Ryan Harper wrote: > > > I'll be sure to use hg export. I thought that inline was preferred rather > > than attachment so that the patch is readable directly in the mail client. > > Ideally, the patch shouldn't word-wrap. I can make them attachments if > > that is the preferred method. > > I've heard people say that they prefer inline, but for me, an attachment is by > far the best option. My client (mutt) can show attachments inline anyway, so > reading the patch is not a problem, but cut-and-pasting from the terminal > certainly can be. Agreed. Now if we can fix the mail clients that send patches as application/octet-stream with don't get auto-inlined. =) > Patches do have a tendency to word-wrap. Many developers work right up to the > 80th column, which means that by the time you add the two characters on the > left for the diff indicators, you're going to wrap. Furthermore, the headers > on the diff often include a full path name and a date, and they wrap most of > the time. Yep. > If you want to cover all bases, you can attach it _and_ paste it inline, but > I'd be happy just with the attachment. There are a few conscientious people > who do that, but I don't want to put too much burden on those people doing > good work for Xen, and I certainly wouldn't insist upon it! OK. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx (512) 838-9253 T/L: 678-9253 ryanh@us.ibm.com