From: Rob Landley <rob@landley.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Ext2 flags shouldn't report "nogrpid".
Date: Mon, 13 Mar 2006 16:08:47 -0500 [thread overview]
Message-ID: <200603131608.47271.rob@landley.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
Signed-off-by: Rob Landley <rob@landley.net>
If I mount ext2 "rw", I want it to say "rw", not "rw,nogrpid".
--
I caught this writing an automated regression test script for the busybox
mount command. The symptom is
/dev/loop0 on /images/ext2.dir type ext2 (rw,nogrpid)
instead of:
/dev/loop0 on /images/ext2.dir type ext2 (rw)
The behavior was introduced by git commit
8fc2751beb0941966d3a97b26544e8585e428c08.
Rob
--
Never bet against the cheap plastic solution.
[-- Attachment #2: ext2.diff --]
[-- Type: text/x-diff, Size: 355 bytes --]
--- linux-2.6.16-rc5/fs/ext2/super.c 2006-02-27 00:09:35.000000000 -0500
+++ linux-2.6.16-rc5.new/fs/ext2/super.c 2006-03-13 15:55:15.000000000 -0500
@@ -210,8 +210,6 @@
if (sbi->s_mount_opt & EXT2_MOUNT_GRPID)
seq_puts(seq, ",grpid");
- else
- seq_puts(seq, ",nogrpid");
#if defined(CONFIG_QUOTA)
if (sbi->s_mount_opt & EXT2_MOUNT_USRQUOTA)
reply other threads:[~2006-03-13 21:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603131608.47271.rob@landley.net \
--to=rob@landley.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.