All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
	"Moore, Eric" <Eric.Moore@lsil.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	James.Bottomley@SteelEye.com, hch@lst.de
Subject: Re: [PATCH ] drivers/base/bus.c - export reprobe
Date: Tue, 14 Mar 2006 09:19:51 -0800	[thread overview]
Message-ID: <20060314171951.GA22678@suse.de> (raw)
In-Reply-To: <20060314170855.GA18342@infradead.org>

On Tue, Mar 14, 2006 at 05:08:55PM +0000, Christoph Hellwig wrote:
> On Tue, Mar 14, 2006 at 07:34:55AM -0800, Greg KH wrote:
> > Also, it looks like USB needs to call this function, (based on the
> > comment)?  Care to switch that code over to have it use it too?
> 
> what comment do you think indicates that?  It's needed for raid drivers
> that

I saw the:

+       if (dev->driver) {^M
+               if (dev->parent)        /* Needed for USB */^M
+                       down(&dev->parent->sem);^M

portion and thought it came from USB core code somewhere.  Or are you
referring to the need for USB-storage here?

> 
>   a) expose physical volumes but set the no_uld_attach flag to hide them
>      from sd
>   b) allow only raid volume creation/deletion so this flag may be set/cleared
>      at runtime

Ok, fair enough, just was a bit confused.

thanks,

greg k-h

  reply	other threads:[~2006-03-14 17:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14  0:52 [PATCH ] drivers/base/bus.c - export reprobe Moore, Eric
2006-03-14  0:52 ` Moore, Eric
2006-03-14 15:34 ` Greg KH
2006-03-14 17:08   ` Christoph Hellwig
2006-03-14 17:19     ` Greg KH [this message]
2006-03-14 17:25       ` Christoph Hellwig
2006-03-14 17:29         ` Greg KH
2006-03-14 17:43           ` James Bottomley
2006-03-14 17:57             ` Greg KH
2006-03-14 22:43               ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2006-03-14 16:18 Moore, Eric
2006-03-14 16:18 ` Moore, Eric
2006-03-14 16:27 ` Jan-Benedict Glaw
2006-03-14 16:50 ` Greg KH
2006-03-14 22:01 Moore, Eric
2006-03-14 22:01 ` Moore, Eric
2006-03-14 22:31 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060314171951.GA22678@suse.de \
    --to=gregkh@suse.de \
    --cc=Eric.Moore@lsil.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.