From: Al Viro <viro@ftp.linux.org.uk>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, becker@scyld.com
Subject: Re: [PATCH] Fix a potential NULL pointer deref in znet
Date: Sun, 19 Mar 2006 00:46:39 +0000 [thread overview]
Message-ID: <20060319004639.GY27946@ftp.linux.org.uk> (raw)
In-Reply-To: <200603190112.31828.jesper.juhl@gmail.com>
On Sun, Mar 19, 2006 at 01:12:31AM +0100, Jesper Juhl wrote:
>
> The coverity checker spotted that we dereference a pointer before we check it
> for NULL in drivers/net/znet.c::znet_interrupt().
> This fixes the issue.
The hell it does. Either interrupt really isn't shared, in which case
this check should be simply removed, or it can be shared, in which case
the code is still buggered.
Please, stop pulling Bunk - _think_ before submitting "make <program> STFU"
patches.
next prev parent reply other threads:[~2006-03-19 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-19 0:12 [PATCH] Fix a potential NULL pointer deref in znet Jesper Juhl
2006-03-19 0:46 ` Al Viro [this message]
2006-03-19 1:01 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060319004639.GY27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=becker@scyld.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.