All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: kaber@trash.net
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [NETFILTER 00/09]: Netfilter update
Date: Mon, 20 Mar 2006 23:42:55 -0800 (PST)	[thread overview]
Message-ID: <20060320.234255.32496441.davem@davemloft.net> (raw)
In-Reply-To: <441F6280.3020201@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Tue, 21 Mar 2006 03:18:40 +0100

> Dave, I'm sorry for the annoyance, but please drop the entire patchset
> except for the H.323 helper. Something is messing up ip6tables on
> one of my systems and the only thing I'm sure of is that its not the
> H.323 helper :)
> 
> I'll resubmit the remaining patches once I know whats going on.

Ok, but please kill trailing whitespace in patches, GIT even warns
about this now and you can check and fix it up before applying a patch
by using:

	git apply --check --whitespace=error-all

So, for example, on this H323 patch we get:

+ git apply --check --whitespace=error-all diff
Adds trailing whitespace.
diff:73:	 
Adds trailing whitespace.
diff:146: *  
Adds trailing whitespace.
diff:156: *	 
Adds trailing whitespace.
diff:171: * 	 
Adds trailing whitespace.
diff:5747: *	 
fatal: 5 lines add trailing whitespaces.

I fixed it up by hand this time, but I may stop doing so in
the future and push it back to you instead :-)

Thanks!

  reply	other threads:[~2006-03-21  7:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-21  1:55 [NETFILTER 00/09]: Netfilter update Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 01/09]: Fix Kconfig typos Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 02/09]: ctnetlink: Fix expectaction mask dumping Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 03/09]: nfnetlink_queue: fix nfnetlink message size Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 04/09]: conntrack: cleanup the conntrack ID initialization Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 05/09]: x_tables: set the protocol family in x_tables targets/matches Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 06/09]: nf_conntrack: support for layer 3 protocol load on demand Patrick McHardy
2006-03-21  1:55 ` [NETFILTER 07/09]: Fix xt_policy address matching Patrick McHardy
2006-03-21  1:56 ` [NETFILTER 08/09]: Add H.323 conntrack/NAT helper Patrick McHardy
2006-03-21  2:03   ` Patrick McHardy
2006-03-21  1:56 ` [NETFILTER 09/09]: futher {ip,ip6,arp}_tables unification Patrick McHardy
2006-03-21  2:11   ` Patrick McHardy
     [not found]     ` <200603211056.02339.dim@sw.ru>
2006-03-21  8:59       ` Patrick McHardy
2006-03-21  9:21         ` Dmitry Mishin
2006-03-21 13:12           ` Patrick McHardy
2006-03-21  2:18 ` [NETFILTER 00/09]: Netfilter update Patrick McHardy
2006-03-21  7:42   ` David S. Miller [this message]
2006-03-21  8:56     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060320.234255.32496441.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.