From: Andi Kleen <ak@suse.de>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
Dave Hansen <haveblue@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] Cpuset: alloc_pages_node overrides cpuset constraints
Date: Wed, 22 Mar 2006 17:33:51 +0100 [thread overview]
Message-ID: <200603221733.51726.ak@suse.de> (raw)
In-Reply-To: <20060318204027.13217.34767.sendpatchset@sam.engr.sgi.com>
On Saturday 18 March 2006 21:40, Paul Jackson wrote:
> --- 2.6.16-rc6.orig/kernel/cpuset.c 2006-03-13 20:19:36.000000000 -0800
> +++ 2.6.16-rc6/kernel/cpuset.c 2006-03-17 21:52:18.000000000 -0800
> @@ -2164,6 +2164,8 @@ int __cpuset_zone_allowed(struct zone *z
> node = z->zone_pgdat->node_id;
> if (node_isset(node, current->mems_allowed))
> return 1;
> + if (gfp_mask & __GFP_NOCPUSET)
> + return 1;
> if (gfp_mask & __GFP_HARDWALL) /* If hardwall request, stop here */
> return 0;
Faster would be if (gfp_mask & (__GFP_NOCPUSET|__GFP_HARDWALL)) { /* sort them out */ }
That would only give a single test for the common case of no such flag set.
-Andi
next prev parent reply other threads:[~2006-03-22 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-18 20:40 [PATCH] Cpuset: alloc_pages_node overrides cpuset constraints Paul Jackson
2006-03-20 7:07 ` Andrew Morton
2006-03-20 8:30 ` Paul Jackson
2006-03-20 15:34 ` Christoph Lameter
2006-03-22 16:33 ` Andi Kleen [this message]
2006-03-22 18:05 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200603221733.51726.ak@suse.de \
--to=ak@suse.de \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.