From: Jon Mason <jdmason@us.ibm.com>
To: Andi Kleen <ak@suse.de>
Cc: Jon Mason <jdmason@us.ibm.com>, Muli Ben-Yehuda <mulix@mulix.org>,
Muli Ben-Yehuda <muli@il.ibm.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/3] x86-64: Calgary IOMMU - hook it in
Date: Thu, 23 Mar 2006 12:58:12 -0600 [thread overview]
Message-ID: <20060323185812.GB30099@us.ibm.com> (raw)
In-Reply-To: <200603231848.19041.ak@suse.de>
On Thu, Mar 23, 2006 at 06:48:18PM +0100, Andi Kleen wrote:
> On Thursday 23 March 2006 18:30, Jon Mason wrote:
>
> > We have a recent modification to this chunk which does both generic and
> > em64t. Since IBM only ships this chip on em64t systems, have the option
> > on amd64 seems wrong.
>
> Please read again what I wrote.
Oh, I agree that it should be there for the generic option, but I think
it is legitimate to have it disabled for MK8. I'll defer to you though
:-)
>
> > Because we need to know the size of the translation tables early, so
> > that we can alloc them from bootmem.
>
> But __setup is parsed during the bootmem phase too. early arguments are only
> needed for things called by setup_arch
I actually tried __setup during development of this code, and it didn't
work. The problem was that __setup, while called early, it is not
called until after setup_arch (and we need to know our table size when
detect_calgary is called at the end of setup_arch).
Thanks,
Jon
> -Andi
>
next prev parent reply other threads:[~2006-03-23 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 8:48 [PATCH 1/3] x86-64: Calgary IOMMU - introduce iommu_detected Muli Ben-Yehuda
2006-03-20 8:54 ` [PATCH 2/3] x86-64: Calgary IOMMU - Calgary specific bits Muli Ben-Yehuda
2006-03-20 8:56 ` [PATCH 3/3] x86-64: Calgary IOMMU - hook it in Muli Ben-Yehuda
2006-03-23 16:36 ` Andi Kleen
2006-03-23 17:30 ` Jon Mason
2006-03-23 17:48 ` Andi Kleen
2006-03-23 18:58 ` Jon Mason [this message]
2006-03-24 3:23 ` Muli Ben-Yehuda
2006-03-23 16:31 ` [PATCH 2/3] x86-64: Calgary IOMMU - Calgary specific bits Andi Kleen
2006-03-23 17:53 ` Muli Ben-Yehuda
2006-03-23 18:02 ` Andi Kleen
2006-03-23 19:03 ` Muli Ben-Yehuda
2006-03-23 21:45 ` Muli Ben-Yehuda
2006-03-23 21:52 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323185812.GB30099@us.ibm.com \
--to=jdmason@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=mulix@mulix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.