Re: [PATCH] Make libata not powerdown drivers on PM_EVENT_FREEZE.

[Nigel Cunningham <ncunningham@cyclades.com>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

Hi.

On Thursday 23 March 2006 23:09, Jens Axboe wrote:
> On Thu, Mar 23 2006, Nigel Cunningham wrote:
> > diff -ruNp 9904-libata-freeze.patch-old/drivers/scsi/libata-scsi.c
> > 9904-libata-freeze.patch-new/drivers/scsi/libata-scsi.c ---
> > 9904-libata-freeze.patch-old/drivers/scsi/libata-scsi.c	2006-03-23
> > 21:16:22.000000000 +1000 +++
> > 9904-libata-freeze.patch-new/drivers/scsi/libata-scsi.c	2006-03-23
> > 21:24:06.000000000 +1000 @@ -419,7 +419,7 @@ int
> > ata_scsi_device_suspend(struct scsi_
> >  	struct ata_port *ap = (struct ata_port *) &sdev->host->hostdata[0];
> >  	struct ata_device *dev = &ap->device[sdev->id];
> >
> > -	return ata_device_suspend(ap, dev);
> > +	return ata_device_suspend(ap, dev, state);
> >  }
>
> Eh this looks odd, you are forgetting to add pm_message_t state as an
> extra argument to that function.
>
> Apart from that, patch looks good. It should definitely be included
> asap.

Good catch! Fixed, will resend.

Thanks!

Nigel

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]