diff for duplicates of <200603232336.19683.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index 0a14381..b5617ac 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,17 @@ Am Thursday 23 March 2006 22:32 schrieb Olof Johansson: > > +static inline int hvc_rtas_write_console(uint32_t vtermno, const char > > *buf, int count) +{ -> > +=A0=A0=A0=A0=A0int done; +> > + int done; > > + -> > +=A0=A0=A0=A0=A0/* if there is more than one character to be displayed,= - wait a bit */ -> > +=A0=A0=A0=A0=A0for (done =3D 0; done < count; done++) {=20 -> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0int result; -> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0result =3D rtas_call(rtascons_p= -ut_char_token, 1, 1, NULL, buf[done]); -> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (result)=20 -> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0break; +> > + /* if there is more than one character to be displayed, wait a bit */ +> > + for (done = 0; done < count; done++) { +> > + int result; +> > + result = rtas_call(rtascons_put_char_token, 1, 1, NULL, buf[done]); +> > + if (result) +> > + break; > > Why introduce a scope-local variable just to check it? -> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if(rtas_call(...)) =A0 wo= -uld be cleaner. +> if(rtas_call(...)) would be cleaner. I don't like doing the important stuff inside of another expression, and I prefer conditions not to have side-effects. @@ -23,11 +20,10 @@ If nobody else has a strong opinion on it, I'd prefer to leave it. BTW, who is the current maintainer of hvc_console? Ryan is working on glibc nowadays, right? -> > +=A0=A0=A0=A0=A0/* Really the fun isn't over until the worker thread br= -eaks down -> > and the +=A0=A0=A0=A0=A0 * tty cleans up */ -> > +=A0=A0=A0=A0=A0if (hvc_rtas_dev) -> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0hvc_remove(hvc_rtas_dev); +> > + /* Really the fun isn't over until the worker thread breaks down +> > and the + * tty cleans up */ +> > + if (hvc_rtas_dev) +> > + hvc_remove(hvc_rtas_dev); > > +} > > +module_exit(hvc_rtas_exit); /* before drivers/char/hvc_console.c */ > diff --git a/a/content_digest b/N1/content_digest index 59da537..3327f0a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,28 +5,27 @@ "Subject\0Re: [Cbe-oss-dev] [patch 02/13] powerpc: add hvc backend for rtas\0" "Date\0Thu, 23 Mar 2006 23:36:19 +0100\0" "To\0cbe-oss-dev@ozlabs.org\0" - "Cc\0linuxppc-dev@ozlabs.org" + "Cc\0Olof Johansson <olof@lixom.net>" Arnd Bergmann <arnd.bergmann@de.ibm.com> - " linux-kernel@vger.kernel.org\0" + linuxppc-dev@ozlabs.org + linux-kernel@vger.kernel.org + " Ryan S. Arnold <rsa@us.ibm.com>\0" "\00:1\0" "b\0" "Am Thursday 23 March 2006 22:32 schrieb Olof Johansson:\n" "> > +static inline int hvc_rtas_write_console(uint32_t vtermno, const char\n" "> > *buf, int count) +{\n" - "> > +=A0=A0=A0=A0=A0int done;\n" + "> > +\302\240\302\240\302\240\302\240\302\240int done;\n" "> > +\n" - "> > +=A0=A0=A0=A0=A0/* if there is more than one character to be displayed,=\n" - " wait a bit */\n" - "> > +=A0=A0=A0=A0=A0for (done =3D 0; done < count; done++) {=20\n" - "> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0int result;\n" - "> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0result =3D rtas_call(rtascons_p=\n" - "ut_char_token, 1, 1, NULL, buf[done]);\n" - "> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (result)=20\n" - "> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0break;\n" + "> > +\302\240\302\240\302\240\302\240\302\240/* if there is more than one character to be displayed, wait a bit */\n" + "> > +\302\240\302\240\302\240\302\240\302\240for (done = 0; done < count; done++) { \n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240int result;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240result = rtas_call(rtascons_put_char_token, 1, 1, NULL, buf[done]);\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (result) \n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240break;\n" ">\n" "> Why introduce a scope-local variable just to check it?\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if(rtas_call(...)) =A0 wo=\n" - "uld be cleaner.\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if(rtas_call(...)) \302\240 would be cleaner.\n" "\n" "I don't like doing the important stuff inside of another expression,\n" "and I prefer conditions not to have side-effects.\n" @@ -35,11 +34,10 @@ "BTW, who is the current maintainer of hvc_console? Ryan is working on\n" "glibc nowadays, right?\n" "\n" - "> > +=A0=A0=A0=A0=A0/* Really the fun isn't over until the worker thread br=\n" - "eaks down\n" - "> > and the +=A0=A0=A0=A0=A0 * tty cleans up */\n" - "> > +=A0=A0=A0=A0=A0if (hvc_rtas_dev)\n" - "> > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0hvc_remove(hvc_rtas_dev);\n" + "> > +\302\240\302\240\302\240\302\240\302\240/* Really the fun isn't over until the worker thread breaks down\n" + "> > and the +\302\240\302\240\302\240\302\240\302\240 * tty cleans up */\n" + "> > +\302\240\302\240\302\240\302\240\302\240if (hvc_rtas_dev)\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240hvc_remove(hvc_rtas_dev);\n" "> > +}\n" "> > +module_exit(hvc_rtas_exit); /* before drivers/char/hvc_console.c */\n" ">\n" @@ -49,4 +47,4 @@ "\n" "\tArnd <><" -4c0cbe36b2e5ebd04f340801980e339912d7609937452b97b6933913a6c15a97 +a8ea9891b86540c6d343fc8b6a1f0ebd338cf2abd6ba9b3e2dfdd5043eaf60d1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.