All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Nigel Cunningham <ncunningham@cyclades.com>,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile.
Date: Fri, 24 Mar 2006 12:36:20 +0100	[thread overview]
Message-ID: <200603241236.20990.ak@suse.de> (raw)
In-Reply-To: <20060324121418.c4c03e1d.khali@linux-fr.org>

On Friday 24 March 2006 12:14, Jean Delvare wrote:
> Hi Nigel, Andi, all,
> 
> > It looks to me like the above commit from Andi causes a compilation failure on 
> > x86_64, because it makes pci_mmcfg_init non static:
> > 
> > arch/x86_64/pci/mmconfig.c:152: error: conflicting types for ‘pci_mmcfg_init’
> > arch/i386/pci/pci.h:85: error: previous declaration of ‘pci_mmcfg_init’ was 
> > here
> > make[1]: *** [arch/x86_64/pci/mmconfig.o] Error 1
> > make: *** [arch/x86_64/pci] Error 2
> 
> I just hit the same compilation failure. Here's a fix which works for
> me.

This was my mistake. I fixed the problem in the wrong patch. And then
Greg submitted only the one patch. I think Andrew fixed it up by 
submitting the other (unrelated) patch which fixes this too.

Thanks.
-Andi


  reply	other threads:[~2006-03-24 11:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-24  5:29 92c05fc1a32e5ccef5e0e8201f32dcdab041524c breaks x86_64 compile Nigel Cunningham
2006-03-24 11:14 ` Jean Delvare
2006-03-24 11:36   ` Andi Kleen [this message]
2006-03-24 12:00     ` Nigel Cunningham
2006-03-24 11:42   ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603241236.20990.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@cyclades.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.