From: Ewan Mellor <ewan@xensource.com>
To: Harry Butterworth <harry@hebutterworth.freeserve.co.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fix for bug#515
Date: Fri, 24 Mar 2006 13:40:09 +0000 [thread overview]
Message-ID: <20060324134008.GC8825@leeni.uk.xensource.com> (raw)
In-Reply-To: <1143205525.7690.2.camel@localhost.localdomain>
On Fri, Mar 24, 2006 at 01:05:24PM +0000, Harry Butterworth wrote:
> # HG changeset patch
> # User harry@localhost.localdomain
> # Node ID 78704d769fb2f758bc9c05b0911081375fae018d
> # Parent 8c21c8ea5fff320d1cc4abd18d11c648cdca322e
> Fix bug 515 by adding a global lock around the hotplug scripts in the
> non-udev hotplug case only.
>
> There are two possible root causes for 515, both of which are only
> problems in the non-udev hotplug case because udev uses udevsend which
> already implements the required serialisation.
>
> 1) Script concurrency.
> 2) Kernel reordering hotplug events.
>
> This changeset fixes (1) but not (2). Since (1) is the problem that
> seems to be happening this is probably OK.
>
> A fix for (2) for the hotplug case might be to add extra serialisation
> using state changes in the store but this would impact all the drivers
> and the code and extra complexity would be redundant once everyone had
> moved to udev. This doesn't seem worthwhile unless we actually start to
> see (2) happening.
Applied, thanks Harry.
Ewan.
prev parent reply other threads:[~2006-03-24 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 13:05 [PATCH] fix for bug#515 Harry Butterworth
2006-03-24 13:40 ` Ewan Mellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324134008.GC8825@leeni.uk.xensource.com \
--to=ewan@xensource.com \
--cc=harry@hebutterworth.freeserve.co.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.