Re: DRIVER vs. PHYSDEVDRIVER for block susbsystem

[Kay Sievers <kay.sievers@vrfy.org>]

On Sat, Mar 25, 2006 at 10:34:21PM +0300, Andrey Borzenkov wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Saturday 25 March 2006 22:24, Kay Sievers wrote:
> 
> > > > No DRIVER matches up the whole chain of devices. But the driver value
> > > > of block is "" which matches successfully the non-match of the values
> > > > it is compared against.
> > > >
> > > > The rules have changed and should work that way:
> > > >
> > > > http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=blob;hb=HEAD;f=et
> > > >c/ud ev/60-persistent-storage.rules
> > >
> > > Those rules will never match for ide-cs or ide-floppy as intended (while
> > > this "fixes" it for ide-cdrom, sure :)
> >
> > Care to explain?
> >
> 
> Sure. As you stated before, 'driver value of block is ""'. The "" can never 
> match "ide-cd|ide-floppy". And non-block are filtered away two lines before.

No, DRIVER matches up the chain of all devices, it has nothing to do
with the event a non-block device. Did you test it?

> > > > We should not introduce any new users of the "device" link or the
> > > > PHYSDEV* values, they will go away some day along with the odd idea
> > > > to distinguish between class and physical devices.
> [...]
> > > In this case adding driver for block devices looks like the right thing,
> > > does not it? Strictly speaking, it could be generalized to "if device
> > > symlink exists, fetch driver from it"; this will go away when sysfs
> > > layout will have changed.
> >
> > No, the block devices don't have a driver.
> >
> 
> Is not this the "odd idea to distinguish between class and physical 
> device"? :)

No, it's not. The correct value for the driver of a blockdev is "", as
there is no driver. Copying the value from the parent would be wrong.

Kay


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel