From: Eric Wong <normalperson@yhbt.net>
To: Ryan Anderson <ryan@michonline.com>
Cc: Junio C Hamano <junkio@cox.net>, git <git@vger.kernel.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH 1/4] send-email: Change from Mail::Sendmail to Net::SMTP
Date: Sat, 25 Mar 2006 16:54:24 -0800 [thread overview]
Message-ID: <20060326005424.GA1773@localdomain> (raw)
In-Reply-To: <20060325235859.GO26071@mythryan2.michonline.com>
Ryan Anderson <ryan@michonline.com> wrote:
> On Sat, Mar 25, 2006 at 02:43:30AM -0800, Eric Wong wrote:
> > Net::SMTP is in the base Perl distribution, so users are more
> > likely to have it. Net::SMTP also allows reusing the SMTP
> > connection, so sending multiple emails is faster.
>
> Overall, I like this set of cleanups, just one thing struck me as,
> "why?"
>
> > if ($quiet) {
> > - printf "Sent %s\n", $subject;
> > + print "Sent $subject\n";
>
> This seems to be a pointless change, and actually, might be long-term
> counterproductive.
Force of habit, I think. I originally rewrote that portion but thought
I reverted it back to the way it was. Besides, it's even slightly
faster this way :) It could still be faster(!) if I just printed a list
(like below).
> Assumption: Eventually, we're going to want to internationalize git.
>
> If that is true, we'll eventually do something like this to lines like
> that:
> printf( gettext("Send %s\n"), $subject);
>
> The alternative:
> print gettext("Send $subject\n");
> does not work.
print gettext('Send '),$subject,"\n";
> (The line that xgettext will see is 'Send $subject\n', but when the
> program actually runs, gettext will see the interpolated version, which
> fails.)
>
> Internationalization may still be a ways off, but I think we're reaching
> the point where it might be something we care to think about.
--
Eric Wong
next prev parent reply other threads:[~2006-03-26 0:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 10:43 send-email: dependency removal, cleanup, + small feature Eric Wong
2006-03-25 10:43 ` [PATCH 1/4] send-email: Change from Mail::Sendmail to Net::SMTP Eric Wong
2006-03-25 23:58 ` Ryan Anderson
2006-03-26 0:54 ` Eric Wong [this message]
2006-03-26 1:09 ` Junio C Hamano
2006-03-26 1:20 ` [PATCH] " Eric Wong
2006-04-26 0:45 ` Martin Langhoff
2006-04-26 20:17 ` Junio C Hamano
2006-04-26 20:24 ` Martin Langhoff
2006-04-28 0:27 ` Eric Wong
2006-04-28 1:04 ` Martin Langhoff
2006-03-25 10:43 ` [PATCH 4/4] send-email: add support for mutt aliases files Eric Wong
2006-03-25 20:31 ` Junio C Hamano
2006-03-25 23:50 ` Ryan Anderson
2006-03-26 1:10 ` [PATCH] send-email: address expansion for common mailers Eric Wong
2006-03-26 1:30 ` Junio C Hamano
2006-03-26 2:44 ` Eric Wong
2006-05-15 2:13 ` [PATCH (resend)] " Eric Wong
2006-05-15 4:12 ` Ryan Anderson
2006-03-25 10:43 ` [PATCH 3/4] send-email: lazy-load Email::Valid and make it optional Eric Wong
2006-03-25 15:07 ` Randal L. Schwartz
2006-03-25 20:33 ` Junio C Hamano
2006-03-26 0:47 ` [PATCH] " Eric Wong
2006-03-25 10:43 ` [PATCH 2/4] send-email: use built-in time() instead of /bin/date '+%s' Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060326005424.GA1773@localdomain \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=greg@kroah.com \
--cc=junkio@cox.net \
--cc=ryan@michonline.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.