All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Schlatterbeck <rsc@runtux.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] compilation error + kernel panic sip-conntrack-nat
Date: Mon, 27 Mar 2006 15:56:37 +0200	[thread overview]
Message-ID: <20060327135637.GA19422@runtux.com> (raw)

The following patch fixes a compilation problem for 2.6.16 (two missing
includes) and a kernel panic on the first sip packets (reproduced with
2.6.15.4 and 2.6.16, tested only with 2.6.16). The kernel-panic fix is
from the mailinglist-archive but obviously didn't yet make it into
the official tree yet.

Note: The FAQ-Entry about SIP 
http://www.netfilter.org/documentation/FAQ/netfilter-faq-1.html#ss1.8
should be updated to point to sip-conntrack-nat, see
http://www.iptel.org/sipalg/
The conntrack module would surely get more testing if it is mentioned in
the FAQ :-)


--- linux/net/ipv4/netfilter/ip_conntrack_sip.c.before-rsc	2006-03-27 08:41:10.000000000 +0200
+++ linux/net/ipv4/netfilter/ip_conntrack_sip.c	2006-03-27 10:18:57.101716429 +0200
@@ -13,6 +13,8 @@
 #include <linux/netfilter.h>
 #include <linux/ip.h>
 #include <linux/ctype.h>
+#include <linux/in.h>
+#include <linux/udp.h>
 #include <net/checksum.h>
 #include <net/udp.h>
 
@@ -296,7 +298,7 @@
 		return NF_ACCEPT;
         }
         
-	ip_ct_refresh_acct(ct, ctinfo, NULL, sip_timeout * HZ);
+	ip_ct_refresh(ct, *pskb, sip_timeout * HZ);
 		
 	spin_lock_bh(&sipbf_lock);
 	


Ralf
-- 
Ralf Schlatterbeck

             reply	other threads:[~2006-03-27 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-27 13:56 Ralf Schlatterbeck [this message]
2006-03-29  8:41 ` [PATCH] compilation error + kernel panic sip-conntrack-nat Patrick McHardy
2006-03-29  9:03   ` Ralf Schlatterbeck
2006-03-29  9:07     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060327135637.GA19422@runtux.com \
    --to=rsc@runtux.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.