From: Matthew Wilcox <matthew@wil.cx>
To: Bodo Eggert <7eggert@gmx.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: [PATCH] Move SG_GET_SCSI_ID from sg to scsi
Date: Mon, 27 Mar 2006 08:20:26 -0700 [thread overview]
Message-ID: <20060327152026.GG3486@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0603271158360.3209@be1.lrz>
On Mon, Mar 27, 2006 at 12:11:14PM +0200, Bodo Eggert wrote:
> > > + __put_user(0, &idp->unused[0]);
> > > + __put_user(0, &idp->unused[1]);
> >
> > Is it time to repurpose the unused bytes for the 64-bit LUN?
>
> ACK, but I didn't find out how to fill it, and having ints instead of
> __uXX made the struct look ugly. Therefore I postponed it to a later patch.
So we don't currently save the scsi_lun anywhere. We, er, translate it
into a 32-bit int, and carry that around. Obviously this is going to
have to change for things like iSCSI, but this is totally offtopic for
your patch. So I agree with you, whoever adds the 64-bit LUN support
gets to patch the ioctl struct too.
next prev parent reply other threads:[~2006-03-27 15:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-26 19:28 [PATCH] Move SG_GET_SCSI_ID from sg to scsi Bodo Eggert
2006-03-26 19:51 ` Arjan van de Ven
2006-03-26 20:08 ` Matthew Wilcox
2006-03-26 20:41 ` Arjan van de Ven
2006-03-26 20:05 ` Matthew Wilcox
2006-03-27 10:11 ` Bodo Eggert
2006-03-27 15:20 ` Matthew Wilcox [this message]
2006-03-27 15:40 ` James Bottomley
2006-03-26 22:30 ` Linus Torvalds
2006-03-26 23:19 ` Jan Engelhardt
2006-03-27 0:06 ` Linus Torvalds
2006-03-27 11:42 ` Bodo Eggert
2006-03-28 9:43 ` Matthias Andree
2006-03-27 15:03 ` Douglas Gilbert
2006-03-27 17:15 ` Linus Torvalds
2006-03-27 17:25 ` Matthew Wilcox
2006-03-27 17:43 ` Linus Torvalds
2006-03-27 19:54 ` Alan Cox
2006-03-27 21:29 ` Douglas Gilbert
2006-03-28 7:37 ` Stefan Richter
2006-03-28 14:17 ` Jan Engelhardt
2006-03-26 23:09 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060327152026.GG3486@parisc-linux.org \
--to=matthew@wil.cx \
--cc=7eggert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.