Re: 2.6.16-mm1

[Jens Axboe <axboe@suse.de>]

On Tue, Mar 28 2006, OGAWA Hirofumi wrote:
> Jens Axboe <axboe@suse.de> writes:
> 
> > On Fri, Mar 24 2006, Brandon Low wrote:
> >
> > Hmm, no luck reproducing this so far, strange. I'm using
> > 2.6.16-block.git cfq branch exclusively, which is the patch you backed
> > out. I guess I'll try 2.6.16-mm1 on the same box next.
> >
> > Can you try 2.6.16-mm1 with this patch applied on top?
> >
> > diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> > index 81edf51..89fcc2c 100644
> > --- a/block/cfq-iosched.c
> > +++ b/block/cfq-iosched.c
> > @@ -1516,6 +1516,7 @@ cfq_cic_rb_add(struct cfq_data *cfqd, st
> >  
> >  	rb_link_node(&cic->rb_node, parent, p);
> >  	rb_insert_color(&cic->rb_node, &ioc->cic_root);
> > +	list_add(&cic->queue_list, &cfqd->cic_list);
> >  	read_unlock(&cfq_exit_lock);
> >  }
> 
> I've got a same oops in 2.6.16-mm1, and this patch seems to fix it at
> least in my case.

Super, it should fix it afaict, but not being able to reproduce I could
not say for sure. Thanks very much for testing and reporting back.

Andrew, can you enable cfq pull again? Thanks.

-- 
Jens Axboe